Skip to content

docs(flowise): sync startup delay options#344

Merged
mberlofa merged 3 commits into
mainfrom
docs/flowise-template-standards-sync
Jul 6, 2026
Merged

docs(flowise): sync startup delay options#344
mberlofa merged 3 commits into
mainfrom
docs/flowise-template-standards-sync

Conversation

@mberlofa

@mberlofa mberlofa commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • document Flowise startup delay values used to serialize first-boot queue migrations
  • update Flowise image/default references to 3.1.3
  • enable and correct Flowise playground defaults and values paths

Validation

  • make site-sync-check CHART=flowise
  • npm run lint
  • npm run format:check
  • npm run build
  • make release-check REPO=site
  • make attribution-check REPO=site

Charts PR: helmforgedev/charts#666
Issue: helmforgedev/charts#633

Summary by CodeRabbit

  • New Features
    • Added Flowise to the playground’s set of configured charts.
  • Changes
    • Updated Helm chart configuration for Flowise and n8n, including revised general settings, namespaced queue options, and improved ingress configuration (host/path fields and related defaults).
  • Bug Fixes
    • Improved queue-mode guidance so worker pods delay until the main service completes startup/migrations.
  • Documentation
    • Refreshed Flowise docs and examples (new image default, startup delay settings, and migration callouts) to match recommended values.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8553690d-a3ad-4cf5-8094-32eb0d6778a9

📥 Commits

Reviewing files that changed from the base of the PR and between 9476050 and 01bd354.

📒 Files selected for processing (3)
  • src/data/playground-configs.ts
  • src/pages/docs/charts/flowise.mdx
  • src/pages/playground.astro
✅ Files skipped from review due to trivial changes (1)
  • src/pages/docs/charts/flowise.mdx
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/pages/playground.astro
  • src/data/playground-configs.ts

📝 Walkthrough

Walkthrough

Flowise playground configuration fields are updated for general, queue, and ingress settings, n8n fields change in the shared playground config source, Flowise is added to the playground site-sync map, and Flowise docs are revised for startup delay and image tag changes.

Changes

Playground config and docs

Layer / File(s) Summary
n8n playground fields
src/data/playground-configs.ts
The n8n general field group removes replica count, adds webhook and editor base URL inputs, and updates the persistence size description.
Flowise general and queue fields
src/data/playground-configs.ts
The Flowise general group replaces replica count with a namespaced field, adds an app URL field, updates the persistence size default, and reworks the queue fields and defaults.
Flowise ingress fields
src/data/playground-configs.ts
The Flowise ingress group changes the hostname shape, adds path and pathType fields, and removes the TLS toggle.
Playground site-sync wiring
src/pages/playground.astro
Flowise is added to siteSyncPlaygroundConfigs in the playground page.
Flowise documentation updates
src/pages/docs/charts/flowise.mdx
The queue-mode example, configuration reference, migration callout, and queue-mode warning text are updated for startup delay and image tag changes.

Estimated code review effort: 2 (Simple) | ~12 minutes

Possibly related PRs

  • helmforgedev/site#322: Also updates src/pages/playground.astro by changing the siteSyncPlaygroundConfigs chart mapping.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: syncing Flowise startup delay options in docs and related config.
Description check ✅ Passed The description covers the summary, validation steps, and linked issue; the blog section is unnecessary here.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/flowise-template-standards-sync

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/data/playground-configs.ts (1)

3726-3783: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Move the Flowise fields out of the n8n config in src/data/playground-configs.ts. The n8n block now defines flowise.* and queue.worker.* keys, while src/pages/playground.astro routes the Flowise slug to chartConfigs.flowise. That leaves Flowise without these controls and pushes invalid values into N8N. Move this General/Queue block under flowise and restore the N8N-specific fields.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/data/playground-configs.ts` around lines 3726 - 3783, The Flowise
General/Queue settings are mistakenly defined under the n8n config, which causes
flowise.* and queue.worker.* values to be applied to the wrong chart. Move this
block from the n8n entry in playground-configs.ts into the flowise entry so
playground.astro can resolve the Flowise slug via chartConfigs.flowise, and
restore the proper N8N-specific fields under n8n instead. Use the existing
General and Queue section names and the flowise/queue.worker field keys to
relocate the controls cleanly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@src/data/playground-configs.ts`:
- Around line 3726-3783: The Flowise General/Queue settings are mistakenly
defined under the n8n config, which causes flowise.* and queue.worker.* values
to be applied to the wrong chart. Move this block from the n8n entry in
playground-configs.ts into the flowise entry so playground.astro can resolve the
Flowise slug via chartConfigs.flowise, and restore the proper N8N-specific
fields under n8n instead. Use the existing General and Queue section names and
the flowise/queue.worker field keys to relocate the controls cleanly.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c33a0221-9602-489e-9a27-47c2c55e193d

📥 Commits

Reviewing files that changed from the base of the PR and between 365449a and 48c094a.

📒 Files selected for processing (3)
  • src/data/playground-configs.ts
  • src/pages/docs/charts/flowise.mdx
  • src/pages/playground.astro

@mberlofa

mberlofa commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Addressed the CodeRabbit playground finding.

What changed:

  • moved Flowise-specific controls out of the n8n playground config and into flowise;
  • restored N8N-specific General and Queue controls under n8n;
  • verified the remaining Flowise controls against the current chart values and did not keep startupDelaySeconds fields because they are not present in the chart contract.

Validation:

  • npm run lint
  • npm run build
  • make site-sync-check CHART=flowise
  • make release-check REPO=site
  • make attribution-check REPO=site
  • git diff --check

This CodeRabbit item was posted in review/comment context, not as an active review thread, so there was no thread ID to resolve.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/data/playground-configs.ts`:
- Around line 3731-3736: The description for the `n8n.webhookUrl` field in
`playground-configs` conflicts with the chart contract by implying
auto-detection from ingress, so update that config entry to match the documented
behavior. Use the `label: 'Webhook URL'` field under `n8n.webhookUrl` and change
the description to state it is the full external URL required for webhook
triggers, without mentioning auto-detection or empty-value fallback.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 62ad1152-e65c-4ead-9ef3-b163fb0f304c

📥 Commits

Reviewing files that changed from the base of the PR and between 48c094a and eaf69c4.

📒 Files selected for processing (1)
  • src/data/playground-configs.ts

Comment thread src/data/playground-configs.ts
mberlofa added a commit to helmforgedev/charts that referenced this pull request Jul 6, 2026
## Summary
- move Flowise template validation into a centralized helper and add
validation unit coverage
- expose startup delay controls for the main server and queue workers
- make the queue+s3 CI fixture deterministic by avoiding first-boot
migration races

## Validation
- helm unittest charts/flowise
- helm lint --strict charts/flowise
- make template-standards-check CHART=flowise
- make standards-check CHART=flowise
- make standards-guard CHART=flowise
- make validate-chart CHART=flowise TIMEOUT=900: FULLY VALIDATED (17
layers)
- make site-sync-check CHART=flowise
- make release-check REPO=charts
- make attribution-check REPO=charts

Site PR: helmforgedev/site#344
Issue: #633

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Added configurable startup delays for the main Flowise server and
queue-mode worker pods.
* Reduced the default number of Flowise replicas for the S3 queue setup
to 1.
* **Bug Fixes**
* Strengthened chart validation to prevent unsupported combinations of
architecture, database/Redis, storage, replica sizing, and S3 settings.
* Prevented user-supplied pod labels from overriding key selector
labels.
* **Tests**
* Added/updated Helm tests to cover configurable startup delays and
validation failures.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: MergeCheck <mergecheck@example.invalid>
@mberlofa mberlofa force-pushed the docs/flowise-template-standards-sync branch from 9476050 to 01bd354 Compare July 6, 2026 12:54
@mberlofa mberlofa merged commit d9f2a88 into main Jul 6, 2026
6 checks passed
@mberlofa mberlofa deleted the docs/flowise-template-standards-sync branch July 6, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant