docs(flowise): sync startup delay options#344
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughFlowise playground configuration fields are updated for general, queue, and ingress settings, n8n fields change in the shared playground config source, Flowise is added to the playground site-sync map, and Flowise docs are revised for startup delay and image tag changes. ChangesPlayground config and docs
Estimated code review effort: 2 (Simple) | ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/data/playground-configs.ts (1)
3726-3783: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winMove the Flowise fields out of the
n8nconfig insrc/data/playground-configs.ts. Then8nblock now definesflowise.*andqueue.worker.*keys, whilesrc/pages/playground.astroroutes the Flowise slug tochartConfigs.flowise. That leaves Flowise without these controls and pushes invalid values into N8N. Move this General/Queue block underflowiseand restore the N8N-specific fields.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/data/playground-configs.ts` around lines 3726 - 3783, The Flowise General/Queue settings are mistakenly defined under the n8n config, which causes flowise.* and queue.worker.* values to be applied to the wrong chart. Move this block from the n8n entry in playground-configs.ts into the flowise entry so playground.astro can resolve the Flowise slug via chartConfigs.flowise, and restore the proper N8N-specific fields under n8n instead. Use the existing General and Queue section names and the flowise/queue.worker field keys to relocate the controls cleanly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/data/playground-configs.ts`:
- Around line 3726-3783: The Flowise General/Queue settings are mistakenly
defined under the n8n config, which causes flowise.* and queue.worker.* values
to be applied to the wrong chart. Move this block from the n8n entry in
playground-configs.ts into the flowise entry so playground.astro can resolve the
Flowise slug via chartConfigs.flowise, and restore the proper N8N-specific
fields under n8n instead. Use the existing General and Queue section names and
the flowise/queue.worker field keys to relocate the controls cleanly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: c33a0221-9602-489e-9a27-47c2c55e193d
📒 Files selected for processing (3)
src/data/playground-configs.tssrc/pages/docs/charts/flowise.mdxsrc/pages/playground.astro
|
Addressed the CodeRabbit playground finding. What changed:
Validation:
This CodeRabbit item was posted in review/comment context, not as an active review thread, so there was no thread ID to resolve. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/data/playground-configs.ts`:
- Around line 3731-3736: The description for the `n8n.webhookUrl` field in
`playground-configs` conflicts with the chart contract by implying
auto-detection from ingress, so update that config entry to match the documented
behavior. Use the `label: 'Webhook URL'` field under `n8n.webhookUrl` and change
the description to state it is the full external URL required for webhook
triggers, without mentioning auto-detection or empty-value fallback.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 62ad1152-e65c-4ead-9ef3-b163fb0f304c
📒 Files selected for processing (1)
src/data/playground-configs.ts
## Summary - move Flowise template validation into a centralized helper and add validation unit coverage - expose startup delay controls for the main server and queue workers - make the queue+s3 CI fixture deterministic by avoiding first-boot migration races ## Validation - helm unittest charts/flowise - helm lint --strict charts/flowise - make template-standards-check CHART=flowise - make standards-check CHART=flowise - make standards-guard CHART=flowise - make validate-chart CHART=flowise TIMEOUT=900: FULLY VALIDATED (17 layers) - make site-sync-check CHART=flowise - make release-check REPO=charts - make attribution-check REPO=charts Site PR: helmforgedev/site#344 Issue: #633 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added configurable startup delays for the main Flowise server and queue-mode worker pods. * Reduced the default number of Flowise replicas for the S3 queue setup to 1. * **Bug Fixes** * Strengthened chart validation to prevent unsupported combinations of architecture, database/Redis, storage, replica sizing, and S3 settings. * Prevented user-supplied pod labels from overriding key selector labels. * **Tests** * Added/updated Helm tests to cover configurable startup delays and validation failures. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: MergeCheck <mergecheck@example.invalid>
9476050 to
01bd354
Compare
Summary
Validation
Charts PR: helmforgedev/charts#666
Issue: helmforgedev/charts#633
Summary by CodeRabbit